Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(frontend): Adding Docker Host Url Prompt #2934

Merged
merged 1 commit into from
Jul 12, 2023
Merged

feature(frontend): Adding Docker Host Url Prompt #2934

merged 1 commit into from
Jul 12, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Jul 12, 2023

This PR updates the request url component to include an extra input for the localhost vs docker host prompt

Changes

  • Adds new docker url component
  • Includes logic for validating and parsing urls

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

https://www.loom.com/share/4ddc663c26934a118175107f01b323cd

@xoscar xoscar self-assigned this Jul 12, 2023
@xoscar xoscar linked an issue Jul 12, 2023 that may be closed by this pull request
error message for endpoint #2910
Closed
@xoscar xoscar marked this pull request as ready for review July 12, 2023 21:51
jorgeepc
jorgeepc approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@jorgeepc jorgeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪄

@xoscar xoscar merged commit e9d5347 into main Jul 12, 2023
@xoscar xoscar deleted the 2910-error-message-for-endpoint branch July 12, 2023 22:11
@olha23
Copy link

olha23 commented Jul 13, 2023

@xoscar cool idea! just make sure that distance between blocks is the same:
Screenshot 2023-07-13 at 1 59 26 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@kdhamric kdhamric Awaiting requested review from kdhamric

@olha23 olha23 Awaiting requested review from olha23

Assignees

@xoscar xoscar

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error message for endpoint
3 participants
@xoscar @olha23 @jorgeepc