Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples(grafana): Update code for Grafana Office Hours #5 #2953

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

adnanrahic
Copy link
Contributor

This PR updated the Grafana example code.

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@adnanrahic adnanrahic self-assigned this Jul 17, 2023
@adnanrahic adnanrahic added the documentation Improvements or additions to documentation label Jul 17, 2023
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1 @@
curl -d '' -H "Content-Type: application/json" -X GET http://localhost:8081/pokemon
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these curls for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of the demo I did on the Office Hours. Showing simple curls before using Tracetest.

@adnanrahic adnanrahic merged commit fd0ff9a into main Jul 17, 2023
@adnanrahic adnanrahic deleted the grafana-office-hours-5 branch July 17, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants