Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): show trace ID on failed tests #2995

Merged
merged 3 commits into from
Jul 28, 2023
Merged

feat(cli): show trace ID on failed tests #2995

merged 3 commits into from
Jul 28, 2023

Conversation

schoren
Copy link
Collaborator

@schoren schoren commented Jul 27, 2023

This PR makes the CLI show the related TraceID for tests that are failing. Example:

On Success:
Screenshot 2023-07-27 at 17 52 27

On failure:
Screenshot 2023-07-27 at 16 07 03

Transactions:
Screenshot 2023-07-27 at 17 53 51

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@schoren schoren linked an issue Jul 27, 2023 that may be closed by this pull request
@kdhamric
Copy link
Collaborator

@schoren Wanted to make sure we are writing the parent trace id on all tests whether they are failing or not.

@schoren
Copy link
Collaborator Author

schoren commented Jul 27, 2023

@kdhamric good catch. I only added it for failure originally. It's updated to show on both cases now

@schoren schoren merged commit f984d51 into main Jul 28, 2023
30 checks passed
@schoren schoren deleted the trace-id-cli branch July 28, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add trace id to tracetest test run output
5 participants