Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): fixing deprecated environment flag #3039

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Aug 8, 2023

This PR fixes the deprecated environment flag from env to environment

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar self-assigned this Aug 8, 2023
@xoscar xoscar marked this pull request as ready for review August 8, 2023 19:19
@@ -73,7 +73,7 @@ func init() {
runCmd.Flags().StringSliceVar(&runParams.RequriedGates, "required-gates", []string{}, "override default required gate. "+validRequiredGatesMsg())

//deprecated
runCmd.Flags().StringVarP(&runParams.EnvID, "env", "e", "", "environment file or ID to be used")
runCmd.Flags().StringVarP(&runParams.EnvID, "environment", "e", "", "environment file or ID to be used")
runCmd.Flags().MarkDeprecated("env", "use --vars instead")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change this line too? MarkDeprecated("environment"...

@xoscar xoscar merged commit 244769e into main Aug 8, 2023
30 checks passed
@xoscar xoscar deleted the fix/deprecated-env-flag branch August 8, 2023 19:36
danielbdias pushed a commit that referenced this pull request Aug 11, 2023
* feat(cli): fixing deprecated environment flag

* feat(cli): fixing deprecated environment flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants