Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme and doc changes #307

Merged
merged 9 commits into from
Apr 21, 2022
Merged

Readme and doc changes #307

merged 9 commits into from
Apr 21, 2022

Conversation

kdhamric
Copy link
Collaborator

This PR...

Changes

  • Added a block to help people know what to test when they try to create a test
  • Added a link to the PMA repo docs
  • Added the button from marketing

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

mathnogueira
mathnogueira approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@mathnogueira mathnogueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

schoren
schoren reviewed Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@schoren schoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good!

@kdhamric kdhamric merged commit 378a919 into main Apr 21, 2022
@kdhamric kdhamric deleted the Readme-and-doc-changes branch April 21, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schoren schoren schoren approved these changes

@mathnogueira mathnogueira mathnogueira approved these changes

@xoscar xoscar Awaiting requested review from xoscar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdhamric @schoren @mathnogueira