Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): using the UIs version endpoint #3147

Merged
merged 2 commits into from
Sep 12, 2023
Merged

feat(cli): using the UIs version endpoint #3147

merged 2 commits into from
Sep 12, 2023

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Sep 11, 2023 •
edited
Loading

This PR updates the CLI to use the version.json endpoint to grab the configuration information

Changes

  • Adds logic to trigger a request to the version.json endpoint
  • Updates version endpoint to use extension file

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

https://www.loom.com/share/e53ee062fffb472eb3df29a6c4f5d1aa

@xoscar xoscar self-assigned this Sep 11, 2023
@xoscar xoscar marked this pull request as ready for review September 11, 2023 22:45
@xoscar xoscar merged commit aea10c8 into main Sep 12, 2023
38 checks passed
@xoscar xoscar deleted the feat/using-ui-version-file branch September 12, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

@danielbdias danielbdias Awaiting requested review from danielbdias

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xoscar @jorgeepc