fix(agent): updating support for otlp datastore #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
commented
Sep 21, 2023
| @@ -100,6 +100,10 @@ func (s *Starter) StartAgent(ctx context.Context, endpoint, name, agentApiKey, u | |||
| ServerURL: endpoint, | |||
| APIKey: agentApiKey, | |||
| Name: name, | |||
| OTLPServer: agentConfig.OtlpServer{ | |||
There was a problem hiding this comment.
This needs to be configurable from the CLI
xoscar
commented
Sep 21, 2023
server/app/app.go
Outdated
| @@ -230,8 +230,8 @@ func (app *App) Start(opts ...appOption) error { | |||
|
|
|||
| tracedbFactory := tracedb.Factory(tracesRepo) | |||
|
|
|||
| eventEmitter := executor.NewEventEmitter(testDB, subscriptionManager) | |||
| registerOtlpServer(app, tracesRepo, runRepo, eventEmitter, dataStoreRepo, tracer) | |||
| // eventEmitter := executor.NewEventEmitter(testDB, subscriptionManager) | |||
There was a problem hiding this comment.
We might need a flag to enable/disable this (?)
There was a problem hiding this comment.
Yes. If we cant have it on cloud, we should disable it via configuration
xoscar
commented
Sep 21, 2023
| @@ -28,13 +24,6 @@ func newForwardIngester(ctx context.Context, batchTimeout time.Duration, remoteI | |||
| traceCache: remoteIngesterConfig.traceCache, | |||
| } | |||
|
|
|||
| err := ingester.connectToRemoteServer(ctx) | |||
There was a problem hiding this comment.
Having a connect here was failing the initialization and we are not connecting to a server "yet"
There was a problem hiding this comment.
We might need to disable all the removed code based on a flag.
The removed code is important in the future when we decide to forward traces from the agent to an OTLP-compatible endpoint. But for now, I think we can remove it.
mathnogueira
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR...
Changes
Fixes
Checklist