Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fixing minor bugs for both the assertion form and the custom table #319

Merged
merged 1 commit into from
Apr 22, 2022
Merged

🐛 Fixing minor bugs for both the assertion form and the custom table #319

merged 1 commit into from
Apr 22, 2022

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Apr 22, 2022

Fixes

  • Style broke for the tables, I think it was caused by an ant update. Still investigating...
  • When editing an assertion the initial selector list was displaying the wrong number of selected spans.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar added this to the MVP milestone Apr 22, 2022
@xoscar xoscar requested a review from kdhamric April 22, 2022 14:10
@xoscar xoscar self-assigned this Apr 22, 2022
kdhamric
kdhamric approved these changes Apr 22, 2022
View reviewed changes
Copy link
Collaborator

@kdhamric kdhamric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@xoscar xoscar merged commit cce970a into main Apr 22, 2022
@xoscar xoscar deleted the fixing-minor-bugs branch April 22, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdhamric kdhamric kdhamric approved these changes

Assignees

@xoscar xoscar

Labels
frontend
Projects
None yet
Milestone
MVPrototype
Development

Successfully merging this pull request may close these issues.
2 participants
@xoscar @kdhamric