fix(server): Fixing nil Trace #3197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
commented
Sep 29, 2023
| if job.Run.Trace == nil { | ||
| newTrace := traces.NewTrace(job.Run.TraceID.String(), []traces.Span{}) | ||
| job.Run.Trace = &newTrace | ||
| } |
There was a problem hiding this comment.
There was a problem caused by this change:
https://github.com/kubeshop/tracetest/pull/3170/files#diff-8477c1b1ce0272a42d729b310d1dacfd4452b274c8de5e0737d701593965b150R84
Which make every incoming trace without spans to be marked as nil, but for no tracing mode, this is expected
jorgeepc
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to validate if a trace is
nilbefore starting to manipulate it as part of the evaluation processChanges
Fixes
Checklist