Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics to http endpoints #3201

Merged
merged 4 commits into from
Oct 3, 2023
Merged

feat: add metrics to http endpoints #3201

merged 4 commits into from
Oct 3, 2023

Conversation

mathnogueira
Copy link
Member

@mathnogueira mathnogueira commented Oct 2, 2023

This PR adds the basic metric instrumentation for HTTP endpoints

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

https://www.loom.com/share/a89db641c7a4432ca2dbf43ebad8c69e

@mathnogueira mathnogueira marked this pull request as ready for review October 3, 2023 18:50
@@ -1,4 +1,4 @@
package tracing
package telemetry
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 ❤️

Copy link
Collaborator

@schoren schoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mathnogueira mathnogueira merged commit 3ae60b0 into main Oct 3, 2023
38 checks passed
@mathnogueira mathnogueira deleted the feat/metrics branch October 3, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants