Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

320 allowing removal of every assertion check from the modal #327

Merged
merged 1 commit into from
Apr 25, 2022
Merged

320 allowing removal of every assertion check from the modal #327

merged 1 commit into from
Apr 25, 2022

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Apr 25, 2022

This PR allows users to delete all of the assertions checks when creating and editing an assertion.

Changes

  • CreateAssertionForm

Fixes

  • Allows removal of all of the assertion checks

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar added this to the MVP milestone Apr 25, 2022
@xoscar xoscar self-assigned this Apr 25, 2022
@xoscar xoscar linked an issue Apr 25, 2022 that may be closed by this pull request
Cannot always delete span assertions #320
Closed
mathnogueira
mathnogueira approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@mathnogueira mathnogueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xoscar xoscar merged commit 5135ad5 into main Apr 25, 2022
@xoscar xoscar deleted the 320-cannot-always-delete-span-assertions branch April 25, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathnogueira mathnogueira mathnogueira approved these changes

@schoren schoren Awaiting requested review from schoren

@kdhamric kdhamric Awaiting requested review from kdhamric

@mortada-codes mortada-codes Awaiting requested review from mortada-codes

Assignees

@xoscar xoscar

Labels
frontend
Projects
None yet
Milestone
MVPrototype
Development

Successfully merging this pull request may close these issues.

Cannot always delete span assertions
2 participants
@xoscar @mathnogueira