Feat/skip trace collection #3351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
requested review from
schoren,
mathnogueira,
jorgeepc and
danielbdias
xoscar
changed the base branch from
feat/add-create-method
to
feat-ux-test-creation
jorgeepc
approved these changes
Nov 15, 2023
xoscar
added a commit
that referenced
this pull request
Nov 21, 2023
* feat(frontend): add trigger type modal (#3326) * feat(frontend): decouple test run page (#3338) Co-authored-by: Oscar Reyes <[email protected]> * Chore/component cleanup (#3357) chore: component cleanup * feat(frontend): UI updates to test trigger tab (#3354) * feat(frontend): add new ux layout to test edit (#3359) * feat: Import Modal (#3360) * feat: Import Modal * chore: component cleanup * Feat/skip trace collection (#3351) feat(BE): Skip Trace Collection * Feat/skip trace collection 2 (#3353) * feat(BE): Skip Trace Collection * feat(FE): Skip Trace Collection * fix: loading state * feat(frontend): add edit test name form (#3363) * feat(frontend): add edit test name form * fix minor issue with form * Fix/name update (#3366) fix: UX improvements * fix(frontend): fix e2e tests (#3365) * fix(frontend): fix e2e tests * fix * feat: UX improvements * fix: popover state * fix(frontend): add variable set selector (#3380) --------- Co-authored-by: Jorge Padilla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the backend logic to skip trace collection from the test configuration or during the test run process by using the context cancellation as a way to stop looking for traces.
Changes
skip_trace_collectioncolumn for tests and test runsFixes
Checklist
Loom video
https://www.loom.com/share/73e65ed2f5bb4a39bf1278a12316953d