Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): fix default summary time #3390

Merged
merged 1 commit into from
Nov 22, 2023
Merged

fix(frontend): fix default summary time #3390

merged 1 commit into from
Nov 22, 2023

Conversation

jorgeepc
Copy link
Contributor

This PR fixes the default summary time (last run time) for tests and test suites.

Changes

  • fix default last run time
  • improve copy for create modal headers
  • code clean up

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Screenshot

Screenshot 2023-11-22 at 12 35 06

@jorgeepc jorgeepc self-assigned this Nov 22, 2023
@jorgeepc jorgeepc requested a review from xoscar November 22, 2023 17:38
xoscar
xoscar approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, great cleanup!

I think in the near future we should think on how to improve the test card visualization to look better with default values

@jorgeepc jorgeepc merged commit 48f9b2a into main Nov 22, 2023
38 checks passed
@jorgeepc jorgeepc deleted the fix-summary-time branch November 22, 2023 21:38
This was referenced Nov 27, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

Assignees

@jorgeepc jorgeepc

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgeepc @xoscar