Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): fix span-naming and empty-attributes rules #3403

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

jorgeepc
Copy link
Contributor

This PR fixes a bug with the span-naming and empty-attributes rules in the trace analyzer. We were throwing analyzer errors about span naming problems for default http spans, and empty tracetest.span.status_description attributes.

Changes

  • add default validation for http spans
  • include the tracetest.span.status_description attribute if it has a value

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

https://www.loom.com/share/94b6587e7b584f228b9fa6477af4217f?sid=55b817a3-28f5-48b6-86e2-024d96246b7e

@jorgeepc jorgeepc self-assigned this Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (83bb2f1) 39.43% compared to head (ca534a7) 39.43%.

Files Patch % Lines
server/traces/span_entitiess.go 0.00% 4 Missing ⚠️
server/linter/rules/ensure_span_naming_rule.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3403      +/-   ##
==========================================
- Coverage   39.43%   39.43%   -0.01%     
==========================================
  Files         222      222              
  Lines       16973    16974       +1     
==========================================
  Hits         6694     6694              
- Misses       9693     9694       +1     
  Partials      586      586              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xoscar xoscar merged commit b46d547 into main Nov 27, 2023
37 of 40 checks passed
@xoscar xoscar deleted the fix-span-naming-empty-attrs-rules branch November 27, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants