Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove some possible panics #3405

Merged
merged 3 commits into from
Nov 29, 2023
Merged

fix: remove some possible panics #3405

merged 3 commits into from
Nov 29, 2023

Conversation

mathnogueira
Copy link
Member

This PR solves some of the possible panics we might get when running tracetest. I used nilaway to detect them. I was going to integrate it on our pipeline, however, it still shows some false positive cases of panics, so I decided to postpone this action.

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

Add your loom video here if your work can be visualized

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (7bbafb4) 39.43% compared to head (924946d) 39.37%.
Report is 4 commits behind head on main.

❗ Current head 924946d differs from pull request most recent head 6145558. Consider uploading reports for the commit 6145558 to get more accurate results

Files Patch % Lines
server/traces/otel_converter.go 0.00% 15 Missing ⚠️
server/tracedb/signalfxdb.go 0.00% 6 Missing ⚠️
server/tracedb/elasticsearchdb.go 0.00% 3 Missing ⚠️
server/tracedb/tempodb.go 0.00% 3 Missing ⚠️
server/tracedb/azureappinsights.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3405      +/-   ##
==========================================
- Coverage   39.43%   39.37%   -0.07%     
==========================================
  Files         222      222              
  Lines       16974    17002      +28     
==========================================
  Hits         6694     6694              
- Misses       9694     9722      +28     
  Partials      586      586              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathnogueira mathnogueira merged commit 567d0be into main Nov 29, 2023
38 checks passed
@mathnogueira mathnogueira deleted the feat/nilaway branch November 29, 2023 16:03
Copy link
Contributor

@danielbdias danielbdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants