Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: environment URL in CLI #3426

Merged
merged 2 commits into from
Dec 5, 2023
Merged

fix: environment URL in CLI #3426

merged 2 commits into from
Dec 5, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Dec 5, 2023

This PR fixes the environment URL generated by the CLI start command. It also adds a fix in the FE router to handle redirects when the path does not match any route.

Changes

  • fix environment URL in CLI
  • fix FE router to handle not matched routes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@jorgeepc jorgeepc self-assigned this Dec 5, 2023
@jorgeepc jorgeepc changed the title Fix router default path fix: environment URL in CLI Dec 5, 2023
@jorgeepc jorgeepc merged commit f59ab68 into main Dec 5, 2023
38 checks passed
@jorgeepc jorgeepc deleted the fix-router-default-path branch December 5, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

Assignees

@jorgeepc jorgeepc

Labels
CLI frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgeepc @xoscar