Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cypress): copy edits #3536

Merged
merged 1 commit into from
Jan 18, 2024
Merged

docs(cypress): copy edits #3536

merged 1 commit into from
Jan 18, 2024

Conversation

adnanrahic
Copy link
Contributor

@adnanrahic adnanrahic commented Jan 17, 2024

This PR updates Cypress recipe copy.

NOTE:

  • The recipe code sample does not match the YouTube video code sample.
  • Which of these is the preferred code sample to show users?

BUG:

  • The code sample is failing one test
  • What should we do to fix?
Running:  home.cy.ts                                                                      (1 of 1)


  Home
    ✓ create a pokemon (4850ms)
    ✓ imports a pokemon (1056ms)
    1) "after all" hook for "deletes a pokemon"


  2 passing (1m)
  1 failing

  1) Home
       "after all" hook for "deletes a pokemon":
     CypressError: Timed out after `60000ms`. The `done()` callback was never invoked!

Because this error occurred during a `after all` hook we are skipping the remaining tests in the current suite: `Home`
      at cypressErr (http://localhost:8081/__cypress/runner/cypress_runner.js:75240:18)
      at Object.errByPath (http://localhost:8081/__cypress/runner/cypress_runner.js:75295:10)
      at http://localhost:8081/__cypress/runner/cypress_runner.js:145790:72

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

Add your loom video here if your work can be visualized

@adnanrahic adnanrahic marked this pull request as ready for review January 17, 2024 19:24
@xoscar
Copy link
Collaborator

xoscar commented Jan 17, 2024

@adnanrahic we improved some parts of the tracetest libs which caused the codebase to change, we'll have to go back and re-record another video for Cypress

@adnanrahic adnanrahic merged commit 8dd27e7 into main Jan 18, 2024
37 checks passed
@adnanrahic adnanrahic deleted the docs-cypress-recipe-2 branch January 18, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants