feat: handle stop run and skip polling during polling step #3552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schoren
force-pushed
the
agent-stop-polling
branch
from
2a693a9
to
6c521ca
Compare
mathnogueira
approved these changes
Jan 22, 2024
|
|
||
| if executor.RunWasUserCancelled(existingRun) { | ||
| existingRun.LastError = nil |
There was a problem hiding this comment.
So even if something went wrong, we gonna ignore it if the process was canceled, right?
There was a problem hiding this comment.
If there was an error, it would happen before the cancellation, so the test would be already stopped and the cancelation would be ignored before this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the polling step in the agent and core server so it can correctly handle skip polling and stop requests.
Loom video
https://www.loom.com/share/2e6c88596633449f87928dae87b89250