Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix delete resource navigation #3647

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

jorgeepc
Copy link
Contributor

This PR fixes the navigation path when a test or testsuite is deleted.

Changes

  • fix navigation path

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@jorgeepc jorgeepc self-assigned this Feb 15, 2024
Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview Feb 15, 2024 5:30pm

Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥂

@@ -20,18 +20,21 @@ const useDeleteResource = () => {
const onConfirmDelete = useCallback(
async (id: string, type: ResourceType) => {
try {
let path = '/tests';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let 👀

@jorgeepc jorgeepc merged commit 2ab2779 into main Feb 15, 2024
39 checks passed
@jorgeepc jorgeepc deleted the fix-delete-resource-navigation branch February 15, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI bugs] Deleting a test navigates back to wizard instead of test list
2 participants