feat(agent): add debug logs #3675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
schoren
force-pushed
the
agent-debug-log
branch
from
0449b44
to
beb5128
Compare
| return | ||
| } | ||
|
|
||
| reconnected, err := c.handleDisconnectionError(err) | ||
| if reconnected { | ||
| logger.Debug("reconnected to data store connection stream") |
There was a problem hiding this comment.
I think this one should be a warning instead of debug, especially because I want to know that the error was handled.
mathnogueira
requested changes
Feb 22, 2024
danielbdias
approved these changes
Feb 22, 2024
jorgeepc
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds debug logs so it's easier to identify issues, mainly when talking with the control plane.
It also fixes the logger configuration to correctly display debug logs when passing the
-vflagChanges
Fixes
Checklist
Loom video
Add your loom video here if your work can be visualized