Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): Adding Span Result Detail Drawer #3680

Merged
merged 2 commits into from
Feb 23, 2024
Merged

feat(frontend): Adding Span Result Detail Drawer #3680

merged 2 commits into from
Feb 23, 2024

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Feb 23, 2024 •
edited
Loading

This PR adds the span result detail for the test spec section

Changes

  • Adds new detail component for span result
  • Changes variable for fixed size list on test specs
  • Updates the information shown for span and span results

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

https://www.loom.com/share/cc2e502a3c9748ec997aad0054542d04

@vercel Vercel
Copy link

vercel bot commented Feb 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 8:30pm

@xoscar xoscar changed the title Feat span result detail feat(frontend): Adding Span Result Detail Drawer Feb 23, 2024
@xoscar xoscar self-assigned this Feb 23, 2024
@xoscar xoscar requested a review from jorgeepc February 23, 2024 20:55
@xoscar xoscar marked this pull request as ready for review February 23, 2024 20:55
jorgeepc
jorgeepc approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@jorgeepc jorgeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! GJ!

@xoscar xoscar merged commit 24d538e into main Feb 23, 2024
39 checks passed
@xoscar xoscar deleted the feat-span-result-detail branch February 23, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xoscar @jorgeepc