Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Adding run by id #3775

Merged
merged 6 commits into from
Apr 5, 2024
Merged

fix(cli): Adding run by id #3775

merged 6 commits into from
Apr 5, 2024

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Apr 4, 2024 •
edited
Loading

This PR fixes the way we handle runs by id by enabling it alongside the run groups feature

Changes

  • Adds support for id when using run groups

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

https://www.loom.com/share/f272c64edcac42dd929cc9b7f772ef78

@vercel Vercel
Copy link

vercel bot commented Apr 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2024 5:21pm

@xoscar xoscar marked this pull request as ready for review April 5, 2024 16:32
@xoscar xoscar merged commit aecf0ab into main Apr 5, 2024
39 checks passed
@xoscar xoscar deleted the fix-run-by-id branch April 5, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@mathnogueira mathnogueira Awaiting requested review from mathnogueira

@schoren schoren Awaiting requested review from schoren

@danielbdias danielbdias Awaiting requested review from danielbdias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xoscar @jorgeepc