fix: don't use buffer and run things async #3826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
schoren
reviewed
Apr 25, 2024
agent/collector/ingester.go
Outdated
Comment on lines
48
to
55
| if startRemoteServer { | ||
| err := ingester.connectToRemoteServer(ctx) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("could not connect to remote server: %w", err) | ||
| } | ||
| // if startRemoteServer { | ||
| // err := ingester.connectToRemoteServer(ctx) | ||
| // if err != nil { | ||
| // return nil, fmt.Errorf("could not connect to remote server: %w", err) | ||
| // } | ||
|
|
||
| go ingester.startBatchWorker() | ||
| } | ||
| // go ingester.startBatchWorker() | ||
| // } |
There was a problem hiding this comment.
I just cleaned the whole thing and removed all unused methods as well.
danielbdias
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the agent collector. Now it's not a
proxyfor open telemetry anymore. It only collects traces for tests and stores them. It also discards the test traces once they are sent back to the server to reduce the memory footprint.Changes
Fixes
Checklist
Loom video
Add your loom video here if your work can be visualized