Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(triggers): Fixing Kafka missing variable on URL #3886

Merged
merged 1 commit into from
May 31, 2024
Merged

fix(triggers): Fixing Kafka missing variable on URL #3886

merged 1 commit into from
May 31, 2024

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented May 31, 2024

This PR fixes a missing entry for the broker URL for kafka trigger to handle expressions

Changes

  • Adds missing expression for kafka url

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar self-assigned this May 31, 2024
@vercel Vercel
Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 4:59pm

@xoscar xoscar marked this pull request as ready for review May 31, 2024 17:00
@xoscar xoscar merged commit 21d9969 into main May 31, 2024
39 checks passed
@xoscar xoscar deleted the fix-kafka-missing-variable branch May 31, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathnogueira mathnogueira mathnogueira approved these changes

@schoren schoren Awaiting requested review from schoren

@jorgeepc jorgeepc Awaiting requested review from jorgeepc

@danielbdias danielbdias Awaiting requested review from danielbdias

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xoscar @mathnogueira