🗳 387 adding gateways, slices, selectors and moving calculations to redux/selectors #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
commented
May 2, 2022
| } | ||
|
|
||
| return `Effects ${spanCount} spans`; | ||
| return `Affects ${spanCount} spans`; |
xoscar
commented
May 2, 2022
| @@ -40,7 +40,7 @@ const CreateAssertionModal = ({testId, span, trace, open, onClose, assertion}: I | |||
| onClose(); | |||
| }, [onClose]); | |||
|
|
|||
| const effectedSpanCount = AssertionService.getEffectedSpansCount(trace, selectorList); | |||
| const affectedSpanCount = useAppSelector(AssertionSelectors.selectAffectedSpanCount(testId, resultId, selectorList)); | |||
There was a problem hiding this comment.
Moved calculations to selectors
xoscar
commented
May 2, 2022
| ) || [] | ||
| ); | ||
| }, [targetSpan, test?.assertions, trace]); | ||
| const assertionsResultList = useAppSelector( |
There was a problem hiding this comment.
More selectors, less react code 😄
xoscar
commented
May 2, 2022
| @@ -92,62 +87,50 @@ const Trace: React.FC<TraceProps> = ({testId, testResultId, onDismissTrace, onRu | |||
| ); | |||
|
|
|||
| useGuidedTour(GuidedTours.Trace); | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
Moving custom logic to hook "usePolling"
xoscar
commented
May 2, 2022
|
|
||
| const {createAssertion, getAssertions, updateAssertion} = endpoints; | ||
|
|
||
| const AssertionGateway = () => ({ |
There was a problem hiding this comment.
Facade to facilitate the usage of the async thunk functions from the redux API slice
xoscar
commented
May 2, 2022
|
|
||
| interface ITestResultListState { | ||
| resultListMap: Record<string, IAssertionResult[]>; | ||
| } |
There was a problem hiding this comment.
New slice that stores the result list info, in the future this will come from the BE
xoscar
commented
May 2, 2022
| @@ -0,0 +1,45 @@ | |||
| import {createSelector} from '@reduxjs/toolkit'; | |||
|
|
|||
xoscar
deleted the
387-post-mvp-improvements-move-calculations-to-reduxselectors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the addition of selectors and slices. It also moves the big calculations out of the component layer and into redux actions, async thunks.
Changes
Fixes
Checklist