Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐹 feat(triggers): Playwright Engine #3922

Merged
merged 5 commits into from
Jul 3, 2024
Merged

🐹 feat(triggers): Playwright Engine #3922

merged 5 commits into from
Jul 3, 2024

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented Jul 3, 2024

This PR adds the playwright engine support from the agents

Changes

  • Adds playwright engine trigger

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar changed the title feat(triggers): Playwright Engine 🐹 feat(triggers): Playwright Engine Jul 3, 2024
@xoscar xoscar marked this pull request as ready for review July 3, 2024 17:43
Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 8:44pm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Comment on lines 69 to 78
// pathPrefix := "/api"
// if c.ServerPath != "" {
// pathPrefix = c.ServerPath
// }

if pathPrefix == "/" {
return ""
}
// if pathPrefix == "/" {
// return ""
// }

return pathPrefix
return ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we undo this code?

@xoscar xoscar merged commit 5890cc0 into main Jul 3, 2024
38 checks passed
@xoscar xoscar deleted the feat-playwright-engine branch July 3, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants