chore(cli): Adding version validation to configure and start
#4027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xoscar
commented
Sep 20, 2024
| @@ -106,6 +116,11 @@ func (c Configurator) Start(ctx context.Context, prev *Config, flags agentConfig | |||
| return nil | |||
| } | |||
|
|
|||
| versionText, isMatching := GetVersion(ctx, cfg) | |||
| if !isMatching && os.Getenv("TRACETEST_DEV") == "" { | |||
There was a problem hiding this comment.
We could do the exit cli here but I thought it was better to do that from the cmd level
schoren
approved these changes
Sep 20, 2024
jorgeepc
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the version validation to the
configureandstartcommands.Changes
Fixes
Checklist
Loom video
Screen.Recording.2024-09-20.at.1.32.11.p.m.mov