Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use selectors to filter spans in assertions #410

Merged
merged 2 commits into from
May 3, 2022
Merged

use selectors to filter spans in assertions #410

merged 2 commits into from
May 3, 2022

Conversation

schoren
Copy link
Collaborator

@schoren schoren commented May 3, 2022

This PR fixes the assertion engine selectors usage. It now can actually filter spans using the selectors package

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@schoren schoren changed the title Assertions engine use selectors to filter spans in assertions May 3, 2022
@schoren schoren requested a review from mathnogueira May 3, 2022 22:37
mathnogueira
mathnogueira approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@mathnogueira mathnogueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@schoren schoren merged commit bdfd16c into main May 3, 2022
@schoren schoren deleted the assertions-engine branch May 3, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathnogueira mathnogueira mathnogueira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schoren @mathnogueira