Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

395 updating the event names #423

Merged
merged 1 commit into from
May 4, 2022
Merged

395 updating the event names #423

merged 1 commit into from
May 4, 2022

Conversation

xoscar
Copy link
Collaborator

@xoscar xoscar commented May 4, 2022

This PR updates the event names to have a better description.

Changes

  • Updates the event string names.

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@xoscar xoscar self-assigned this May 4, 2022
@xoscar xoscar linked an issue May 4, 2022 that may be closed by this pull request
Clean up names for Google Analytic events #395
Closed
9 tasks
@xoscar xoscar added this to the MVProduct milestone May 4, 2022
mathnogueira
mathnogueira approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@mathnogueira mathnogueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xoscar xoscar merged commit 9433b0a into main May 4, 2022
@xoscar xoscar deleted the 395-clean-up-names-for-google-analytic-events branch May 4, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathnogueira mathnogueira mathnogueira approved these changes

@kdhamric kdhamric Awaiting requested review from kdhamric

Assignees

@xoscar xoscar

Labels
None yet
Projects
None yet
Milestone
MVProduct
Development

Successfully merging this pull request may close these issues.

Clean up names for Google Analytic events
2 participants
@xoscar @mathnogueira