fix: analytics client #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
requested changes
May 5, 2022
There was a problem hiding this comment.
Hey @mathnogueira, I had a talk with Ken and he wanted us to use dashes instead of underscores for the analytics events, is that something that is causing issues?
|
Yes @xoscar, the endpoint we use to send data from the backend to GA doesn't allow dashes on the name of the event. It only accepts alphanumeric and underscores. |
xoscar
approved these changes
May 5, 2022
|
I think we shifted to dashes instead of underscores in the event names being passed to GA so we could distinguish our events from GA automatic events. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes insecure TLS connection
Changes
Fixes
Checklist