🐛 426 bug enable json comparison #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectors from the modal
…ed-on-spans-currently-selected' into 214-assertions-with-no-filters-defined-should-match-all-spans
…d-match-all-spans
…d-match-all-spans
…-spans' into 426-bug-enable-json-comparison
xoscar
commented
May 5, 2022
| @@ -11,7 +11,7 @@ const ErrorBoundary: React.FC<IErrorBoundaryProps> = ({error}) => { | |||
| <S.Container> | |||
| <CloseCircleFilled style={{color: 'red', fontSize: 32}} /> | |||
| <Typography.Title level={2}>Something went wrong!</Typography.Title> | |||
| <div style={{display: 'grid', gap: 8, gridTemplateColumns: '1fr 1fr'}}>{error.toString()}</div> | |||
| <div style={{display: 'flex', maxWidth: '800px', padding: '24px'}}>{error.toString()}</div> | |||
There was a problem hiding this comment.
Fixing the style for the error boundary message
xoscar
commented
May 5, 2022
| } | ||
|
|
||
| return `value ${compareOperator} \`${comparisonValue}\``; | ||
| if (isJson(comparisonValue)) { |
There was a problem hiding this comment.
Checking if its a potential JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug we had when trying to compare json strings.
Changes
Fixes
Checklist
Screenshots