Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support empty selector #445

Merged
merged 2 commits into from
May 6, 2022
Merged

feat: support empty selector #445

merged 2 commits into from
May 6, 2022

Conversation

mathnogueira
Copy link
Member

@mathnogueira mathnogueira commented May 5, 2022 •
edited by schoren
Loading

This PR enables an empty selector. The behavior for such selector is to select all spans in the tree.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@mathnogueira mathnogueira requested a review from schoren May 5, 2022 22:43
schoren
schoren approved these changes May 6, 2022
View reviewed changes
Copy link
Collaborator

@schoren schoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job keeping the docs updated

@mathnogueira mathnogueira merged commit 2ba9515 into main May 6, 2022
@mathnogueira mathnogueira deleted the feat/empty-selector branch May 6, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schoren schoren schoren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathnogueira @schoren