💅🏽 461 [New UX] Trace View # 3 (Test Results) #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
commented
May 11, 2022
| @@ -21,7 +21,6 @@ describe('Show Trace', () => { | |||
| cy.get('[data-cy=span-details-attributes]').should('be.visible'); | |||
| cy.get('[data-cy=empty-assertion-table]').should('be.visible'); | |||
|
|
|||
| cy.get('[id*=tab-test-results').click(); | |||
| cy.get('[data-cy=test-results]').should('be.visible'); | |||
| cy.get('[data-cy=test-results]').should('exist'); | |||
There was a problem hiding this comment.
The test results its only partially displayed when the trace view loads
xoscar
commented
May 11, 2022
| @@ -24,12 +24,6 @@ body { | |||
| background: #fbfbff; | |||
| } | |||
|
|
|||
| .ant-typography { | |||
There was a problem hiding this comment.
This was a wrong move, it was overwriting the color for the whole app 🥴
xoscar
commented
May 11, 2022
| @@ -0,0 +1,94 @@ | |||
| import {Badge, Typography} from 'antd'; | |||
| import {useSelector} from 'react-redux'; | |||
There was a problem hiding this comment.
Moving it to its own component folder
xoscar
commented
May 11, 2022
| onSelectSpan={onSelectSpan} | ||
| selectedSpan={selectedSpan} | ||
| /> | ||
| <TraceDrawer visiblePortion={visiblePortion} testResultDetails={testResultDetails} onSelectSpan={onSelectSpan} /> |
There was a problem hiding this comment.
Trace drawer is whatever we show at the bottom of the page
xoscar
commented
May 11, 2022
| return ( | ||
| <ResizableDrawer open min={visiblePortion} max={max}> | ||
| <TraceTimeline | ||
| <TestResults |
There was a problem hiding this comment.
Now we show the test results instead of the timeline chart.
kdhamric
approved these changes
May 11, 2022
There was a problem hiding this comment.
I think the current component of TraceResult expands bigger the actual screen.
We need to take a look at this @xoscar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is the first pass for the test results drawer. We'll be waiting for the final designs to fully implement the changes.
This PR moves the test results from the span detail/tab section to the bottom drawer.
Changes
Fixes
Checklist
https://www.loom.com/share/432e43f773d64935b8d7e67de18445fb