[454] add tests to components folder #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoferraro
force-pushed
the
feature/components_testing
branch
from
3beda58
to
70a9bdc
Compare
cescoferraro
changed the title
cescoferraro
changed the title
cescoferraro
force-pushed
the
feature/components_testing
branch
from
124d29e
to
3452f15
Compare
xoscar
approved these changes
May 17, 2022
| cursor: pointer; | ||
| color: ${({isSelected = false}) => (isSelected ? '#61175E' : '#9AA3AB')}; | ||
| color: ${({$isSelected = false}) => ($isSelected ? '#61175E' : '#9AA3AB')}; |
There was a problem hiding this comment.
what's the idea behind this?
| selectedType: SupportedDiagrams; | ||
| } | ||
|
|
||
| const DiagramSwitcher: React.FC<IDiagramSwitcherProps> = ({onSearch, onTypeChange, selectedType}) => { | ||
| const DiagramSwitcher: React.FC<IProps> = ({onSearch, onTypeChange, selectedType}) => { |
There was a problem hiding this comment.
I like big names but I'm open to move the props interface for each component to IProps 😄
| </Menu.SubMenu> | ||
| </S.NavMenu> | ||
| <S.NavMenu | ||
| selectedKeys={[pathname]} |
There was a problem hiding this comment.
I usually prefer components over jsons, maybe we can discuss what's the advantage/disadvantage
| @@ -0,0 +1,14 @@ | |||
| import {MenuInfo} from 'rc-menu/lib/interface'; | |||
There was a problem hiding this comment.
Just a small comment, you don't have to add the .tsx extension if the file doesn't explicitly use JSX
| @@ -0,0 +1,15 @@ | |||
| import {useCallback} from 'react'; | |||
| import {useStore} from 'react-redux'; | |||
There was a problem hiding this comment.
This store is from the react-flow package not from react-redux
cescoferraro
force-pushed
the
feature/components_testing
branch
from
4005e81
to
a5cfd97
Compare
cescoferraro
force-pushed
the
feature/components_testing
branch
from
dbb558b
to
608ea41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add tests to the components located at the components folder
Changes
Checklist