feat: endpoint to rerun test assertions on result #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schoren
requested changes
May 13, 2022
server/executor/assertion_runner.go
Outdated
| @@ -160,6 +160,23 @@ func (e *defaultAssertionRunner) setResults(result *openapi.TestRunResult, testR | |||
| result.AssertionResultState = allTestsPassed | |||
| } | |||
|
|
|||
| func (e *defaultAssertionRunner) RunAssertions(request AssertionRequest) { | |||
| e.inputChannel <- request | |||
| func (e *defaultAssertionRunner) RunAssertions(ctx context.Context, result openapi.TestRunResult) error { | |||
There was a problem hiding this comment.
This is adding an unnecesary responsibility to this function. I think the controller can easily do this setup and keep the assertion runner just running assertions
mathnogueira
force-pushed
the
feat/rerun-test-result-endpoint
branch
from
da79bdd
to
86945a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an endpoint
/tests/:testID/results/:resultID/rerunto rerun the assertion engine on a result.Checklist