add newSelectorLogic method #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
requested changes
May 19, 2022
There was a problem hiding this comment.
Hey @cescoferraro I left some comments and concerns. Let me know what you think
| @@ -0,0 +1,20 @@ | |||
| import {IItemSelector} from '../../types/Assertion.types'; | |||
|
|
|||
| export function newSelectorLogic(selectorList: IItemSelector[]): string { | |||
There was a problem hiding this comment.
Let's move this to the Assertion service
There was a problem hiding this comment.
I think we can change this to be more verbose by doing something like:
const getFilters = (selectorList) => {
return selectorList.map(({propertyName, operator, value, valueType}) => `${propertyName} ${operator || '='} ${getValue(value, valueType)}`);
}
const result `span[${getFilters(selectorList).join(' ')}]`;
| result += selector.propertyName; | ||
| result += selector.operator ? ` ${selector.operator.toLowerCase()} ` : '='; | ||
| // add quotes if value is a string | ||
| if (selector.valueType === 'stringValue') result += `'`; |
There was a problem hiding this comment.
I think we should have a more complex way of creating this chunk to support the other value types.
There was a problem hiding this comment.
Something like getValueString(value, valueType);
Then we can decide how to create each of them
xoscar
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR create a method to transform
selectorList: IItemSelector[]to a selector string described hereChanges
Checklist