Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cli tests pipeline #516

Merged
merged 2 commits into from
May 20, 2022
Merged

feat: cli tests pipeline #516

merged 2 commits into from
May 20, 2022

Conversation

mathnogueira
Copy link
Member

@mathnogueira mathnogueira commented May 19, 2022

This PR adds a workflow to run tests on the CLI module when something there changes. It also skips the backend checks if nothing has changed.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@mathnogueira mathnogueira marked this pull request as ready for review May 19, 2022 21:12
@@ -5,8 +5,10 @@ on:
pull_request:
branches:
- main
paths:
- server/**
Copy link
Member Author

@mathnogueira mathnogueira May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the server tests only run when something inside the directory server changes. Otherwise, this check will be skipped.

@mathnogueira mathnogueira requested a review from schoren May 20, 2022 13:05
@@ -0,0 +1,2 @@
test:
Copy link
Member Author

@mathnogueira mathnogueira May 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a new makefile instead of using the root one because the CLI probably gonna be extracted to an individual repo later. So I want to keep it as isolated as possible.

It still has a dependency on the openapi files, but that can be solved later

Copy link
Collaborator

@schoren schoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mathnogueira mathnogueira merged commit fbe66a5 into main May 20, 2022
@mathnogueira mathnogueira deleted the feat/cli-tests branch May 20, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants