Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spans extra data #520

Merged
merged 2 commits into from
May 20, 2022
Merged

Add spans extra data #520

merged 2 commits into from
May 20, 2022

Conversation

schoren
Copy link
Collaborator

@schoren schoren commented May 20, 2022

This PR adds missing info for spans

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@schoren schoren merged commit c04f483 into main May 20, 2022
@schoren schoren deleted the add-missing-span-fields branch May 20, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants