🖼 522 adding multiple design and UX fixes #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
xoscar
commented
May 24, 2022
| @@ -28,7 +28,7 @@ export const PseudoSelector = styled.div` | |||
| gap: 4px; | |||
| `; | |||
|
|
|||
| export const Check = styled(Space)` | |||
| export const Check = styled.div` | |||
There was a problem hiding this comment.
This was adding some unnecessary styling
xoscar
commented
May 24, 2022
| <S.DeleteCheckIcon | ||
| onClick={() => { | ||
| CreateAssertionModalAnalyticsService.onRemoveCheck(); |
There was a problem hiding this comment.
There will be scenarios where we will be diplaying both CTAs
xoscar
commented
May 24, 2022
| @@ -46,8 +45,8 @@ const Span = ({id = '', name = '', attributes = {}, startTime = '', endTime = '' | |||
| return {...map, [spanAttribute.name]: SpanAttribute(rawSpanAttribute)}; | |||
| }, {}); | |||
|
|
|||
| const duration = startTime && endTime ? differenceInSeconds(parseISO(startTime), parseISO(endTime)) + 1 : 0; | |||
|
|
|||
| const duration = Number(attributes['tracetest.span.duration']) || 0; | |||
There was a problem hiding this comment.
Name and duration are now coming from the attributes object
cescoferraro
approved these changes
May 25, 2022
| @@ -28,7 +28,7 @@ export const PseudoSelector = styled.div` | |||
| gap: 4px; | |||
| `; | |||
|
|
|||
| export const Check = styled(Space)` | |||
| export const Check = styled.div` | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some missing UX pieces to the assertion form and the home page.
Changes
Fixes
Checklist