🦾 525 adding versioning and edit mode for test definitions #575
Conversation
| @@ -123,4 +125,41 @@ describe('Create Assertion', () => { | |||
| cy.get('[data-cy=assertion-card-list]').should('be.visible'); | |||
| cy.get('[data-cy=assertion-card]').should('have.lengthOf', 2); | |||
| }); | |||
|
|
|||
| it('should publish the changes', () => { | |||
| @@ -42,10 +46,12 @@ const AssertionCard: React.FC<TAssertionCardProps> = ({ | |||
| </S.SelectorListText> | |||
| <S.SpanCountText>{spanCountText}</S.SpanCountText> | |||
| </div> | |||
| <div> | |||
| <S.ActionsContainer> | |||
There was a problem hiding this comment.
We are now showing the draft and deleted tags
| @@ -0,0 +1,22 @@ | |||
| import {Modal} from 'antd'; | |||
There was a problem hiding this comment.
We are now alerting the user that there is a version mismatch before opening the assertion form
| return ( | ||
| <Context.Provider value={contextValue}> | ||
| {children} | ||
| <AssertionFormConfirmModal |
There was a problem hiding this comment.
Adding the confirm modal
| return ( | ||
| <S.TestHeader> | ||
| <S.Content> | ||
| <S.BackIcon data-cy="test-header-back-button" onClick={onBack} /> | ||
| <S.TestName data-cy="test-details-name">{name}</S.TestName> | ||
| <S.TestName data-cy="test-details-name"> |
|
|
||
| const TraceActions: React.FC = () => { | ||
| const {definitionList, publish, cancel} = useTestDefinition(); | ||
| const pendingCount = definitionList.filter(({isDraft}) => isDraft).length; |
There was a problem hiding this comment.
New edit actions content.
| open({ | ||
| isEditing: false, | ||
| defaultValues: { | ||
| selectorList: |
There was a problem hiding this comment.
opening the assertion form with the selected span details
| <TestDefinitionProvider testId={testId} runId={runId}> | ||
| <AssertionFormProvider testId={testId}> | ||
| <TestRunProvider testId={testId} runId={runId}> | ||
| <TestRunProvider testId={testId} runId={runId}> |
There was a problem hiding this comment.
Moving the providers as some of them have dependencies
|
|
||
| const update = useCallback( |
There was a problem hiding this comment.
Clean up, moving things to hooks and adding side effects
| const reset = useCallback(() => { | ||
| dispatch(resetAction()); | ||
| }, [dispatch]); | ||
|
|
There was a problem hiding this comment.
Test Definition Slice proxy actions
| export type TCrudResponse = { | ||
| definitionList: TTestDefinitionEntry[]; | ||
| change: TChange; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Leaving the async ones here, the rest are moved to the slice
|
|
||
| const TestSelectors = () => ({ | ||
| selectDefinitionList, | ||
| selectIsLoading: createSelector(stateSelector, ({isLoading}) => isLoading), |
| @@ -6,6 +6,13 @@ export type TRawTestDefinition = TTestSchemas['TestDefinition']; | |||
| export type TTestDefinitionEntry = { | |||
| selector: string; | |||
| assertionList: TAssertion[]; | |||
| isDraft: boolean; | |||
There was a problem hiding this comment.
Added draft and deleted booleans so we can display them on the cards
This PR adds versioning to the FE and enables users to draft changes until they are ready to publish or if they want to revert all to the previous state.
Changes
Fixes
Checklist