Add assertion check in attribute list #582
Conversation
| const onCopy = (value: string) => { | ||
| navigator.clipboard.writeText(value); | ||
| }; |
There was a problem hiding this comment.
Moving the onCopy function here to avoid creating a function for each attribute row.
| const assertions = useAppSelector(state => | ||
| AssertionSelectors.selectResultAssertionsBySpan(state, testId || '', resultId, span?.id || '') | ||
| ); |
There was a problem hiding this comment.
Calling this new selector to get the formatted assertion object.
|
|
||
| const filterRequestList = (attributeList: TSpanFlatAttribute[]) => | ||
| attributeList?.filter(a => HttpRequestAttributeList.includes(a.key) || a.key.includes('http.request')); | ||
|
|
||
| const filterResponseList = (attributeList: TSpanFlatAttribute[]) => | ||
| attributeList?.filter(a => HttpResponseAttributeList.includes(a.key) || a.key.includes('http.request')); | ||
| attributeList?.filter(a => HttpResponseAttributeList.includes(a.key) || a.key.includes('http.response')); |
There was a problem hiding this comment.
Fixing this issue. We were displaying request fields in the response tab.
| @@ -4,6 +4,8 @@ import TestMock from '../../../models/__mocks__/Test.mock'; | |||
| import TestHeader from '../TestHeader'; | |||
|
|
|||
| test('SpanAttributesTable', () => { | |||
| const result = render(<TestHeader onBack={jest.fn()} test={TestMock.model()} testState={TestState.CREATED} />); | |||
| const result = render( | |||
| <TestHeader onBack={jest.fn()} test={TestMock.model()} testState={TestState.CREATED} testVersion={1} /> | |||
There was a problem hiding this comment.
Types were failing for this component. It was missing the testVersion.
| @@ -18,11 +18,11 @@ test('useDAGChart with filled span', () => { | |||
| duration: 10, | |||
| signature: [], | |||
| attributeList: [], | |||
| startTime: '', | |||
| startTime: 0, | |||
There was a problem hiding this comment.
Same here. Types failing.
| @@ -17,9 +17,46 @@ const selectAffectedSpanList = createSelector(stateSelector, paramsSelector, (st | |||
| return trace?.spans.filter(({id}) => spanIdList.includes(id)) || []; | |||
| }); | |||
|
|
|||
| const selectResultAssertionsBySpan = createSelector( | |||
There was a problem hiding this comment.
New selector that transforms the run data into a hashed object by attribute (filtered by span), something like this:
{
"cloud.availability_zone": {
"failed": [
{
"id": "span[tracetest.span.type = \"database\" service.name = \"pokeshop\"]",
"label": "database pokeshop "
},
{
"id": "span[tracetest.span.type = \"database\"]",
"label": "database "
}
],
"passed": [
{
"id": "span[name = \"pg.query:SELECT\" tracetest.span.type = \"database\" service.name = \"pokeshop\" db.system = \"postgresql\" db.name = \"pokeshop\" db.user = \"ashketchum\"]",
"label": "pg.query:SELECT database pokeshop postgresql pokeshop ashketchum "
}
]
}
}
| <AttributeRow attribute={attribute} key={attribute.key} onCreateAssertion={onCreateAssertion} /> | ||
| <AttributeRow | ||
| assertionsFailed={assertions?.[attribute.key]?.failed} | ||
| assertionsPassed={assertions?.[attribute.key]?.passed} |
There was a problem hiding this comment.
I would just pass the assertion as a prop.
There was a problem hiding this comment.
Thanks @cescoferraro
I don't want to pass the whole object to the row if it's not needed. Here I'm looking for the attribute.key in the assertions object. With this we avoid having the assertions in every AttributeRow.
This PR adds the
assertion checkinformation next to each attribute in the span detail list.Changes
Fixes
Checklist
Loom
https://www.loom.com/share/ca75b63c0d6d45d59642e01ba75a37ae
Coverage