Add execution time in test run response #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathnogueira
requested changes
Jun 1, 2022
server/model/run.go
Outdated
|
|
||
| func (r Run) Copy(testVersion int) Run { | ||
| r.Results = nil | ||
| r.Trace = nil |
There was a problem hiding this comment.
Trace should be kept. This is being called by the rerun command and today it doesn't (and shouldn't) retrigger the transaction to run the test, it assumes the trace didn't change and only re-execute the assertion engine using the latest test definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds execution time to the api response. It returns the diff in seconds from
createdAtto eithercompletedAtif the test completed, ortime.Now()if the test is not completed.To ensure that run dates and other info is correctly set, I've centralized the state updating into functions within the model.
Changes
executionTimefield to openapiRestRunExecutionTime()func tomodel.RunChecklist