Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: sort tests by newest first #615

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Fix: sort tests by newest first #615

merged 1 commit into from
Jun 2, 2022

Conversation

schoren
Copy link
Collaborator

@schoren schoren commented Jun 1, 2022

This PR adds createdAt field to test and sorts sql query.

Changes

  • add Test.createdAt internally
  • add sorting to get tests query

Fixes

  • test sort order

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@schoren schoren requested a review from mathnogueira June 1, 2022 17:52
@schoren schoren linked an issue Jun 1, 2022 that may be closed by this pull request
Tests are not shown newest first #606
Closed
xoscar
xoscar approved these changes Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please!

@schoren schoren merged commit 9525133 into main Jun 2, 2022
@schoren schoren deleted the fix-tests-order branch June 2, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathnogueira mathnogueira mathnogueira approved these changes

@xoscar xoscar xoscar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests are not shown newest first
3 participants
@schoren @mathnogueira @xoscar