Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest drawer behaviour #620

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Latest drawer behaviour #620

merged 1 commit into from
Jun 2, 2022

Conversation

cescoferraro
Copy link
Contributor

@cescoferraro cescoferraro commented Jun 1, 2022 •
edited
Loading

This PR make open drawerState not to be the max height the drawer can be set to

Changes

  • adds a DrawerState.MAX to the drawerState
  • default chevron orientation to match open/close action

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@cescoferraro cescoferraro changed the title latest drawer behaviour [WIP] latest drawer behaviour Jun 2, 2022
@cescoferraro cescoferraro self-assigned this Jun 2, 2022
@cescoferraro cescoferraro changed the title [WIP] latest drawer behaviour Latest drawer behaviour Jun 2, 2022
@cescoferraro cescoferraro merged commit a2532c0 into main Jun 2, 2022
@mathnogueira mathnogueira deleted the drawer-ux branch June 25, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeepc jorgeepc jorgeepc approved these changes

@xoscar xoscar xoscar approved these changes

Assignees

@cescoferraro cescoferraro

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cescoferraro @jorgeepc @xoscar