-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update test using definition file #638
Conversation
On "What should happen if the id doesn't exist in the server? Should the CLI fail or should we ignore it and create a new test?" Can the system create the test with the given id (ie specify the id rather than let the system autodefine it)? If it can, I would create the test using the specified id. |
Right now our backend doesn't allow this option. Everytime you call |
Yes, the backend doesn't allow incoming IDs. Also, given that this is an |
Just a correction there: Updating and Creating a test in the CLI are done by the same command. The decision of creating or updating the test depends on the value of the id on the test definition. If it is present, it becomes an update test request, otherwise, it would be a create test request. I don't think the id should matter so much that the user might want to choose it. If the id is important, we should think about a human-readable id alias (kind of what confluence does with its pages). Now about the question, I think that behavior could be configurable. A suggestion would be:
It could be the other way around as well: fail by default and allow the user to override that behavior |
We need a good bit more planning and consensus building around the CLI. Lets keep things as basic as possible, doing a bare MVP. We will shift into planning mode next week. |
Sure. I'll keep it as it is then. The CLI will fail if an invalid id is provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR makes the CLI update the test in case the
id
field is present in it.Questions
Checklist