add Kens changes #77
Merged
add Kens changes #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povilasv
commented
Mar 14, 2022
api/openapi.yaml
Outdated
| @@ -290,21 +299,33 @@ components: | |||
| trace: | |||
| type: object | |||
| description: Trace in standard OTEL format, only set when getting single test result | |||
| Attribute: | |||
There was a problem hiding this comment.
Did we remove attirbute on purpose here?
There was a problem hiding this comment.
I removed it because it was not being referenced anywhere in the file... can add it back if it is needed.
olensmar
reviewed
Mar 14, 2022
Changed Result to TestRunResult
Added uuid per @olensmar and removed the TestResult object as @mortada-codes is going to look at methods and decide
|
Can't approve my PR, but LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.