Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-list.md: create postsubmit prow job that updates after changes to sigs.yaml #321

Open
dhiller opened this issue Sep 5, 2024 · 4 comments

Comments

@dhiller
Copy link
Contributor

dhiller commented Sep 5, 2024

Is your feature request related to a problem? Please describe:
Currently, whenever sigs.yaml is updated, sig-list.md (which is generated from sigs.yaml needs to get updated by calling:

make generate

Describe the solution you'd like:
A way that tells the user that they need to update sig-list.md by running the above command before the merge is completed.

Easiest might be a presubmit job that calls the target and checks whether the git state is clean.

Describe alternatives you've considered:
Variants of that might be:

  • a postsubmit that is executed after changes to sigs.yaml or
  • a periodic
    either way they call the target and create a pull request afterwards.

Additional context:

/good-first-issue

@dhiller
Copy link
Contributor Author

dhiller commented Sep 5, 2024

/area automation

@kubevirt-bot
Copy link

@dhiller: The label(s) area/automation cannot be applied, because the repository doesn't have them.

In response to this:

/area automation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dhiller
Copy link
Contributor Author

dhiller commented Sep 5, 2024

/label good-first-issue

@kubevirt-bot
Copy link

@dhiller: Can not set label good-first-issue: Must be member in one of these teams: [kubevirtorg-label]

In response to this:

/label good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants