This repository has been archived by the owner on Jun 13, 2023. It is now read-only.
Fix kubevirt-web-ui for kubevirt-apb #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The playbook runs in a container already authenticated with the cluster. Remove root and remove copying around the config.
The default is still kubevirt-web-ui.
Not needed and causing issues in some environments.
kubevirt-bot
added
release-note-none
|
@rthallisey , do you think the parameters (names, values) used on command-line match what will go from UI ? |
mareklibra
changed the title
|
I hate to merge this with CI not passing, but this issue looks unrelated. This fix is critical and Marek and I have valided this fix independently. |
ngavrilo
pushed a commit
to ngavrilo/kubevirt-ansible
that referenced
this pull request
Dec 10, 2018
* Web ui fixes for containerized env The playbook runs in a container already authenticated with the cluster. Remove root and remove copying around the config. * Make kubevirt-web-ui namespace configurable The default is still kubevirt-web-ui. * Do not gather facts Not needed and causing issues in some environments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does Adapts kubevirt-web-ui deployment for container (kubevirt-apb) environment:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Verified on fresh (today's) 3.11 OC in Upshift.
Unfortunately, I was not able to execute kubevirt-apb from UI, but mimicked on command-line:
The
docker.io/mareklibra/kubevirt-apb:latestis built from kubevirt-apb master using thismareklibra:web-ui.from.kubevirt-apb.Backport to release-0.9 follows.
Release note: