Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: Add workaround for corrupted image pulls with podman #3639

Merged

Conversation

brianmcarey
Copy link
Member

What this PR does / why we need it:

There are a number of jobs that are failing to pull images due to corruption and a crc32mismatch[1]

There is an open issue for this problem in the podman repo[2] that suggests this change as a workaround.

This workaround should be removed when the related issues are resolved.

[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/12677/pull-kubevirt-e2e-k8s-1.31-sig-compute/1833657514537783296#1:build-log.txt%3A262
[2] containers/podman#23822
[3] zlib-ng/zlib-ng#1772

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @dhiller @xpivarc

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


There are a number of jobs that are failing to pull images due to
corruption and a crc32mismatch[1]

There is an open issue for this problem in the podman repo[2] that
suggests this change as a workaround.

This workaround should be removed when the related issues are resolved.

[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/12677/pull-kubevirt-e2e-k8s-1.31-sig-compute/1833657514537783296#1:build-log.txt%3A262
[2] containers/podman#23822
[3] zlib-ng/zlib-ng#1772

Signed-off-by: Brian Carey <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Sep 11, 2024
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2024
@kubevirt-bot kubevirt-bot merged commit 16816d3 into kubevirt:main Sep 11, 2024
5 checks passed
brianmcarey added a commit to brianmcarey/project-infra that referenced this pull request Sep 23, 2024
…an (kubevirt#3639)"

The fix for the issue that this workaround was added for has been
included in Fedora 40.

```
[root@b873a1829fa1 /]# cat /etc/redhat-release
Fedora release 40 (Forty)
[root@b873a1829fa1 /]# rpm -qa | grep zlib-ng
zlib-ng-compat-2.1.7-2.fc40.x86_64
```

This reverts commit 16816d3.

Signed-off-by: Brian Carey <[email protected]>
kubevirt-bot pushed a commit that referenced this pull request Sep 23, 2024
…an (#3639)" (#3666)

The fix for the issue that this workaround was added for has been
included in Fedora 40.

```
[root@b873a1829fa1 /]# cat /etc/redhat-release
Fedora release 40 (Forty)
[root@b873a1829fa1 /]# rpm -qa | grep zlib-ng
zlib-ng-compat-2.1.7-2.fc40.x86_64
```

This reverts commit 16816d3.

Signed-off-by: Brian Carey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants