Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): search spans from extension tracers when object name is specified #369

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

xuqingyun
Copy link
Collaborator

Description

  • when searched object has no events during this period, try to discover any possible spans from extension tracers.

Related issues

Special notes for your reviewer:

@xuqingyun xuqingyun changed the title feat(frontend): search spans from extension tracers when object name is specified wip: feat(frontend): search spans from extension tracers when object name is specified Oct 8, 2024
@xuqingyun xuqingyun force-pushed the git-xqy/search_from_extension branch from df20cd3 to 0e47d68 Compare October 8, 2024 10:17
@xuqingyun xuqingyun changed the title wip: feat(frontend): search spans from extension tracers when object name is specified feat(frontend): search spans from extension tracers when object name is specified Oct 8, 2024
@xuqingyun xuqingyun force-pushed the git-xqy/search_from_extension branch from 0e47d68 to 756f654 Compare October 8, 2024 12:34
@xuqingyun xuqingyun force-pushed the git-xqy/search_from_extension branch from 756f654 to 71760a4 Compare October 9, 2024 06:10
@xuqingyun xuqingyun force-pushed the git-xqy/search_from_extension branch from 71760a4 to e6c150f Compare October 9, 2024 06:11
@xuqingyun xuqingyun requested a review from SOF3 October 10, 2024 06:37
Copy link
Member

@SOF3 SOF3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as a temporary fix. We probably need to refactor the tracecache in the future anyway to allow better flexibility with the overall UX and performance.

@SOF3 SOF3 added this pull request to the merge queue Oct 14, 2024
Merged via the queue into kubewharf:main with commit c3cea2f Oct 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants